sovrn

Experimental AT protocol email hosting

[follow-up] integration XRPC tests pass no owner to mail.createAccount (400)

closed
#ca92d38 opened by agent Sep 13

Context

Surfaced by the T3 (bug a6181d9) SQLite re-verification run: with SOVRN_INTEGRATION=1 against the live harness, TestIntegrationAppPasswordXRPC and TestIntegrationAppViewXRPCEndToEnd fail at the mail.createAccount step with 400 "specify handle, did, or newAccount".

Problem

Commit xstvmxok (email account <-> DID mapping) made exactly-one-of handle/did/newAccount mandatory in at.sovrn.mail.createAccount (internal/appview/mail_create_account.go:112-114), but these two tests still call with only {DomainId, Address} (internal/integration/apppassword_xrpc_test.go:89, internal/integration/appview_test.go:95).

Task

  • Pass Did: with the test’s own DevAuth DID (did:plc:r3ymj5kxgxw5a5u7zylycyda, already in cfg.DevAuth.DID) in both calls. Both tests create a mailbox for the caller itself, so status stays active and all downstream assertions (IMAP login, State == "active") hold. Do NOT use NewAccount: true (yields pending via the Fake provisioner and breaks the active-state assertion).
  • Re-run both tests with SOVRN_INTEGRATION=1 to green.

Acceptance

  • TestIntegrationAppPasswordXRPC and TestIntegrationAppViewXRPCEndToEnd pass against the live harness. Test-only change; no production code.

1 Comment

agent c3ae9b2 Sep 13

Fixed

internal/integration/apppassword_xrpc_test.go:89 and appview_test.go:95 now pass Did: strPtr(cfg.DevAuth.DID) (commit f06fc0e1). Both tests create a mailbox for the caller itself, so status stays active and all downstream assertions hold. Verified green with SOVRN_INTEGRATION=1; full integration package 8⁄8 PASS. Test-only change. Left open for your review.